Skip to content

[fix](binlog) Report missing row binlog for INCR queries#65481

Open
TsukiokaKogane wants to merge 2 commits into
apache:masterfrom
TsukiokaKogane:fix_incr_error_message
Open

[fix](binlog) Report missing row binlog for INCR queries#65481
TsukiokaKogane wants to merge 2 commits into
apache:masterfrom
TsukiokaKogane:fix_incr_error_message

Conversation

@TsukiokaKogane

@TsukiokaKogane TsukiokaKogane commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #65309

Related PR: #xxx

Problem Summary:

INCR analysis constructed the row-binlog table wrapper before validating that ROW binlog was enabled. Tables without ROW binlog therefore hit an unmessaged precondition in getRowBinlogMeta(), returning an empty detailMessage. Validate INCR conditions before wrapper construction so clients receive the actionable analysis error.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@TsukiokaKogane

TsukiokaKogane commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@TsukiokaKogane TsukiokaKogane force-pushed the fix_incr_error_message branch from fdd5d3a to 0d0d948 Compare July 11, 2026 10:41
@TsukiokaKogane

TsukiokaKogane commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29729 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0d0d948ee5b2f5a8322f827c926493912925a160, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17896	4120	4114	4114
q2	2014	312	208	208
q3	10340	1459	847	847
q4	4679	470	341	341
q5	7523	850	569	569
q6	191	182	139	139
q7	772	845	631	631
q8	9347	1614	1781	1614
q9	5788	4431	4449	4431
q10	6773	1789	1518	1518
q11	496	362	312	312
q12	708	550	448	448
q13	18066	3338	2771	2771
q14	265	266	259	259
q15	q16	796	775	715	715
q17	1006	963	1062	963
q18	7054	5865	5558	5558
q19	1323	1248	1101	1101
q20	761	668	531	531
q21	5904	2592	2349	2349
q22	456	375	310	310
Total cold run time: 102158 ms
Total hot run time: 29729 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4482	4351	4461	4351
q2	303	327	216	216
q3	4604	4958	4383	4383
q4	2175	2221	1420	1420
q5	4406	4398	4357	4357
q6	231	173	130	130
q7	2088	2056	1721	1721
q8	2661	2293	2202	2202
q9	8248	8058	7799	7799
q10	4756	4725	4263	4263
q11	592	453	412	412
q12	755	755	562	562
q13	3299	3557	3020	3020
q14	311	313	277	277
q15	q16	735	730	661	661
q17	1394	1339	1364	1339
q18	8188	7468	7324	7324
q19	1187	1113	1094	1094
q20	2219	2210	1938	1938
q21	5366	4714	4569	4569
q22	523	459	410	410
Total cold run time: 58523 ms
Total hot run time: 52448 ms

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 77.78% (7/9) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 180355 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0d0d948ee5b2f5a8322f827c926493912925a160, data reload: false

query5	4326	630	497	497
query6	480	226	203	203
query7	4931	615	346	346
query8	344	194	171	171
query9	8771	4091	4045	4045
query10	448	356	307	307
query11	5907	2320	2160	2160
query12	161	102	103	102
query13	1252	613	467	467
query14	6223	5290	5001	5001
query14_1	4300	4327	4304	4304
query15	220	211	189	189
query16	989	483	461	461
query17	962	719	599	599
query18	2474	499	358	358
query19	209	200	154	154
query20	114	108	117	108
query21	234	158	132	132
query22	13641	13612	13416	13416
query23	17490	16593	16168	16168
query23_1	16233	16296	16291	16291
query24	7519	1776	1324	1324
query24_1	1347	1296	1310	1296
query25	593	487	409	409
query26	1338	368	224	224
query27	2614	627	395	395
query28	4431	2046	2051	2046
query29	1140	679	491	491
query30	328	263	226	226
query31	1128	1106	1005	1005
query32	119	66	62	62
query33	525	333	265	265
query34	1195	1150	632	632
query35	776	802	683	683
query36	1422	1399	1184	1184
query37	164	115	95	95
query38	1880	1695	1660	1660
query39	920	916	898	898
query39_1	877	929	893	893
query40	248	159	144	144
query41	65	62	67	62
query42	93	89	90	89
query43	322	323	280	280
query44	1489	808	781	781
query45	203	192	192	192
query46	1125	1237	748	748
query47	2327	2345	2150	2150
query48	403	401	293	293
query49	583	416	327	327
query50	1069	414	329	329
query51	10624	10822	10725	10725
query52	88	89	76	76
query53	276	284	199	199
query54	296	230	228	228
query55	74	71	69	69
query56	287	290	289	289
query57	1416	1359	1297	1297
query58	274	265	255	255
query59	1584	1670	1434	1434
query60	302	267	263	263
query61	154	148	152	148
query62	695	641	579	579
query63	245	202	207	202
query64	2847	1050	881	881
query65	4857	4827	4785	4785
query66	1852	502	389	389
query67	29604	29447	29305	29305
query68	2945	1556	1030	1030
query69	392	304	272	272
query70	1056	980	992	980
query71	356	340	310	310
query72	3091	2787	2377	2377
query73	820	785	423	423
query74	5128	4954	4788	4788
query75	2627	2571	2231	2231
query76	2323	1181	776	776
query77	354	395	287	287
query78	12217	12431	11802	11802
query79	1409	1132	780	780
query80	1308	568	467	467
query81	535	325	283	283
query82	639	163	121	121
query83	400	318	285	285
query84	327	164	128	128
query85	966	615	516	516
query86	432	292	291	291
query87	1820	1817	1769	1769
query88	3763	2840	2840	2840
query89	472	403	354	354
query90	1906	209	200	200
query91	203	193	163	163
query92	65	62	63	62
query93	1763	1535	943	943
query94	736	364	319	319
query95	773	498	493	493
query96	1090	827	325	325
query97	2679	2682	2539	2539
query98	218	206	202	202
query99	1146	1167	1016	1016
Total cold run time: 265831 ms
Total hot run time: 180355 ms

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0d0d948ee5b2f5a8322f827c926493912925a160, data reload: false

query1	0.01	0.01	0.01
query2	0.10	0.05	0.07
query3	0.25	0.13	0.13
query4	1.61	0.14	0.14
query5	0.24	0.22	0.22
query6	1.24	1.10	1.04
query7	0.04	0.01	0.01
query8	0.05	0.04	0.04
query9	0.39	0.30	0.30
query10	0.60	0.55	0.55
query11	0.18	0.14	0.14
query12	0.18	0.14	0.15
query13	0.48	0.48	0.49
query14	1.01	1.02	1.00
query15	0.62	0.60	0.60
query16	0.31	0.34	0.31
query17	1.09	1.10	1.06
query18	0.22	0.21	0.21
query19	2.05	1.91	1.93
query20	0.02	0.01	0.02
query21	15.43	0.21	0.14
query22	4.96	0.05	0.06
query23	16.14	0.31	0.13
query24	2.92	0.41	0.34
query25	0.11	0.05	0.05
query26	0.73	0.21	0.14
query27	0.04	0.05	0.03
query28	3.58	0.88	0.56
query29	12.52	4.04	3.22
query30	0.27	0.16	0.17
query31	2.77	0.62	0.32
query32	3.23	0.59	0.48
query33	3.30	3.24	3.25
query34	15.50	4.22	3.54
query35	3.55	3.54	3.53
query36	0.57	0.43	0.42
query37	0.08	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.17	0.15
query41	0.08	0.04	0.03
query42	0.03	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 96.81 s
Total hot run time: 25.07 s

@TsukiokaKogane

TsukiokaKogane commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

run fe_ut

@TsukiokaKogane

TsukiokaKogane commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29642 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c8c864a50a02016e6347e0be88b37e63f979e18f, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17709	4176	4079	4079
q2	2070	331	205	205
q3	10253	1423	816	816
q4	4684	473	342	342
q5	7483	854	584	584
q6	184	176	151	151
q7	767	849	618	618
q8	9632	1523	1518	1518
q9	6122	4369	4368	4368
q10	6834	1800	1515	1515
q11	509	351	319	319
q12	758	543	442	442
q13	18086	3288	2793	2793
q14	262	259	241	241
q15	q16	780	766	723	723
q17	1035	1023	1007	1007
q18	6903	5805	5533	5533
q19	1375	1298	1098	1098
q20	745	623	569	569
q21	5967	2685	2417	2417
q22	440	358	304	304
Total cold run time: 102598 ms
Total hot run time: 29642 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4517	4497	4440	4440
q2	295	317	221	221
q3	4581	4968	4420	4420
q4	2072	2182	1373	1373
q5	4467	4383	4322	4322
q6	237	186	132	132
q7	2109	1966	1615	1615
q8	2594	2238	2151	2151
q9	8062	7700	7882	7700
q10	4713	4746	4243	4243
q11	572	423	558	423
q12	746	749	543	543
q13	3328	3537	2995	2995
q14	318	314	274	274
q15	q16	707	731	640	640
q17	1403	1362	1341	1341
q18	8156	7434	7177	7177
q19	1076	1085	1056	1056
q20	2223	2245	1955	1955
q21	5277	4699	4465	4465
q22	531	476	411	411
Total cold run time: 57984 ms
Total hot run time: 51897 ms

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 179813 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c8c864a50a02016e6347e0be88b37e63f979e18f, data reload: false

query5	4334	643	495	495
query6	544	234	224	224
query7	4921	610	347	347
query8	358	196	179	179
query9	8826	4136	4080	4080
query10	507	350	343	343
query11	5924	2338	2172	2172
query12	168	104	102	102
query13	1364	618	443	443
query14	6297	5281	5030	5030
query14_1	4312	4279	4294	4279
query15	224	217	186	186
query16	1029	503	434	434
query17	1155	731	587	587
query18	2499	476	354	354
query19	219	196	154	154
query20	116	107	109	107
query21	236	161	141	141
query22	13738	13634	13440	13440
query23	17463	16456	16130	16130
query23_1	16272	16268	16225	16225
query24	7830	1765	1316	1316
query24_1	1323	1310	1252	1252
query25	557	434	364	364
query26	1347	377	223	223
query27	2561	606	386	386
query28	4456	2056	2001	2001
query29	1087	624	468	468
query30	346	256	226	226
query31	1138	1104	981	981
query32	101	61	66	61
query33	530	312	246	246
query34	1203	1131	649	649
query35	766	778	710	710
query36	1383	1417	1235	1235
query37	157	108	93	93
query38	1918	1690	1641	1641
query39	947	964	954	954
query39_1	914	900	917	900
query40	269	163	141	141
query41	71	65	64	64
query42	95	95	94	94
query43	329	332	283	283
query44	1502	789	799	789
query45	221	194	179	179
query46	1119	1198	763	763
query47	2389	2360	2275	2275
query48	402	420	298	298
query49	578	425	324	324
query50	1047	410	327	327
query51	10837	10836	10749	10749
query52	85	89	79	79
query53	261	287	202	202
query54	299	232	227	227
query55	74	71	70	70
query56	331	281	287	281
query57	1472	1410	1343	1343
query58	357	264	265	264
query59	1603	1648	1461	1461
query60	317	290	269	269
query61	180	175	175	175
query62	724	659	593	593
query63	254	213	211	211
query64	3019	1207	993	993
query65	4915	4775	4778	4775
query66	1844	573	375	375
query67	29526	28831	29393	28831
query68	3332	1533	1041	1041
query69	446	305	272	272
query70	1078	977	969	969
query71	362	310	310	310
query72	3123	2709	2381	2381
query73	872	822	455	455
query74	5164	4959	4753	4753
query75	2615	2578	2228	2228
query76	2333	1189	770	770
query77	354	384	290	290
query78	12265	12463	11693	11693
query79	1523	1224	778	778
query80	1287	535	449	449
query81	550	318	278	278
query82	715	157	130	130
query83	363	326	288	288
query84	287	159	131	131
query85	1024	605	512	512
query86	485	317	280	280
query87	1828	1815	1736	1736
query88	3825	2800	2766	2766
query89	456	417	355	355
query90	1921	199	195	195
query91	235	191	160	160
query92	63	60	56	56
query93	1768	1498	986	986
query94	779	331	305	305
query95	803	491	553	491
query96	1031	747	358	358
query97	2703	2666	2573	2573
query98	222	204	198	198
query99	1171	1176	1014	1014
Total cold run time: 268569 ms
Total hot run time: 179813 ms

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.03 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c8c864a50a02016e6347e0be88b37e63f979e18f, data reload: false

query1	0.00	0.00	0.00
query2	0.11	0.05	0.05
query3	0.29	0.13	0.14
query4	1.62	0.14	0.15
query5	0.28	0.23	0.22
query6	1.25	1.06	1.10
query7	0.06	0.01	0.01
query8	0.07	0.03	0.04
query9	0.40	0.34	0.33
query10	0.57	0.57	0.60
query11	0.19	0.14	0.14
query12	0.18	0.15	0.15
query13	0.49	0.50	0.49
query14	1.04	1.01	1.01
query15	0.64	0.59	0.60
query16	0.32	0.34	0.33
query17	1.10	1.11	1.13
query18	0.22	0.22	0.20
query19	2.04	2.01	1.90
query20	0.01	0.02	0.01
query21	15.42	0.18	0.14
query22	5.04	0.05	0.06
query23	16.11	0.33	0.12
query24	2.98	0.44	0.33
query25	0.13	0.05	0.06
query26	0.83	0.22	0.16
query27	0.06	0.03	0.04
query28	3.54	0.92	0.56
query29	12.48	3.97	3.18
query30	0.28	0.16	0.14
query31	2.77	0.59	0.31
query32	3.23	0.59	0.50
query33	3.15	3.16	3.19
query34	15.53	4.21	3.49
query35	3.57	3.55	3.56
query36	0.61	0.42	0.43
query37	0.09	0.06	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.17 s
Total hot run time: 25.03 s

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 33.33% (3/9) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 77.78% (7/9) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner
@924060929 924060929 Awaiting requested review from 924060929 924060929 is a code owner
@englefly englefly Awaiting requested review from englefly englefly is a code owner
@starocean999 starocean999 Awaiting requested review from starocean999 starocean999 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] There's no error message for select @incr

2 participants

@TsukiokaKogane @hello-stephen