[improvement](log) Fix English grammar issues in FE/BE log messages#61705
Open
morningman wants to merge 6 commits intoapache:masterfrom
Open
[improvement](log) Fix English grammar issues in FE/BE log messages#61705morningman wants to merge 6 commits intoapache:masterfrom
morningman wants to merge 6 commits intoapache:masterfrom
Conversation
morningman
requested review from
CalvinKirs,
dataroaring,
gavinchou,
w41ter and
zclllyybb
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Issue Number: close #xxx Problem Summary: FE log messages contain widespread non-idiomatic English grammar patterns inherited from Chinese-English direct translation. These patterns affect log readability and professionalism. Specifically: 1. "finished to <verb>" used instead of "Finished <verb>ing" (~95 places) 2. "begin to <verb>" used instead of "Beginning to <verb>" (~40 places) 3. "start to <verb>" used instead of "Starting to <verb>" (~7 places) 4. Acronyms not properly capitalized: "gc" -> "GC", "ldap" -> "LDAP" 5. Minor spelling fix: "effected" -> "affected" in JdbcClient 6. Inconsistent capitalization of log message first letter None - Test: No need to test (log message text-only changes, no logic change) - Behavior changed: No - Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
FE log messages lack standardized rules for grammar, log levels, and
output volume. Code review has no formal checklist for verifying log
quality. This leads to issues such as Chinglish patterns ("finished to"),
excessive INFO logging on idle cycles, and full Thrift object
serialization in log messages.
### Release note
None
### Check List (For Author)
- Test: No need to test (documentation-only change)
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve? Issue Number: close #xxx Problem Summary: 1. Reduced duplicated and spammy logs in fs_file_cache_storage.cpp by changing `LOG(INFO)` to `VLOG_DEBUG`. 2. Standardized BE logging grammar across ~130 files by fixing Chinglish patterns such as 'start to', 'begin to', 'finished to', 'can not' and typos like 'destoried' and 'envorinment'. 3. Ensured that key log lines start with an uppercase letter, following Doris logging standards. ### Release note None ### Check List (For Author) - Test: Manual test - Behavior changed: No - Does this need documentation: No
Issue Number: close #xxx
Problem Summary:
1. Standardized FE and BE logging grammar based on AGENTS.md rules ('Start [verb]ing', 'Begin to [verb]', 'Finished [verb]ing').
2. Reduced massive log spam in fs_file_cache_storage.cpp.
3. Corrected misspellings (e.g. 'destoried', 'envorinment', 'founded', 'can not' -> 'cannot') and capitalized key info logs according to community standards.
None
- Test: Manual test
- Behavior changed: No
- Does this need documentation: No
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26804 ms |
TPC-DS: Total hot run time: 168643 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.