Skip to content

branch-4.0: [fix](packed-file) Fix packed file cache cleanup issue #59892 #60024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 1 commit into from
Closed

branch-4.0: [fix](packed-file) Fix packed file cache cleanup issue #59892 #60024

github-actions wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 19, 2026

Cherry-picked from #59892

@liaoxin01
[fix](packed-file) Fix packed file cache cleanup issue (#59892)
cd6bce1 
Previously, file cache used packed file path as cache key, which caused
cache entries to be orphaned when stale rowsets were cleaned up (cleanup
uses segment path as key).

This fix moves the cache layer from inner reader to PackedFileReader
wrapper level, ensuring:
1. Cache key = hash(segment_path.filename()) - matches cleanup key
2. Cache size = segment size - correct boundary
3. Each segment has independent cache entry - no interference
@github-actions github-actions bot requested a review from yiguolei as a code owner January 19, 2026 08:05
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 19, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 19, 2026
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 19, 2026

run buildall

@liaoxin01 liaoxin01 closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen @liaoxin01 @dataroaring