[Fix](StreamingJob) fix the first split task scheduled and fe restart remainsplit relay problem #59883
+40
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes issues in the StreamingJob functionality related to split task scheduling and FE restart scenarios. Specifically, it addresses the problem where after a job's first split task is scheduled from the initial offset, if FE restarts while the task is running or failed, the split needs to be properly restored from metadata.
Changes:
- Enhanced logging to include complete split information
- Improved error handling for split deserialization failures
- Added logic to handle offset provider replay when FE restarts with an empty persist state but existing metadata
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MySqlSourceReader.java | Changed logging to output full split information instead of just split ID |
| StreamingJobUtils.java | Added exception handling for split deserialization and changed exception type to JobException |
| JdbcSourceOffsetProvider.java | Restructured replay logic to handle FE restart scenarios where offsetProviderPersist is null but metadata exists |
| StreamingInsertJob.java | Simplified condition for replaying offset provider to always attempt replay when provider exists |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fe/fe-core/src/main/java/org/apache/doris/job/util/StreamingJobUtils.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/job/offset/jdbc/JdbcSourceOffsetProvider.java
Show resolved
Hide resolved
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31978 ms |
TPC-DS: Total hot run time: 173145 ms |
ClickBench: Total hot run time: 26.75 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Member
Author
|
run cloud_p0 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
CalvinKirs
approved these changes
Jan 15, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
… remainsplit relay problem (#59883) ### What problem does this PR solve? Related PR: #58898 After the Job is created for the first time, starting from the initial offset, the task for the first split is scheduled, When the task status is running or failed, If FE restarts, the split needs to be restore from the meta again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #58898
After the Job is created for the first time, starting from the initial offset,
the task for the first split is scheduled, When the task status is running or failed,
If FE restarts, the split needs to be restore from the meta again.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)