Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Jan 14, 2026

…(#59315)
#59315
before

            Block block;
            block.insert({ColumnUInt8::create(1), std::make_shared<DataTypeUInt8>(), ""});
            int result = -1;
            RETURN_IF_ERROR(ctx->execute(&block, &result));
            DCHECK(result != -1);
            auto column = block.get_by_position(result).column;
            DCHECK(column->size() == 1);

now

            ColumnWithTypeAndName result;
            RETURN_IF_ERROR(ctx->execute_const_expr(result));
            DCHECK(result.column->size() == 1);

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…pache#59315)

before
```C++
            Block block;
            block.insert({ColumnUInt8::create(1), std::make_shared<DataTypeUInt8>(), ""});
            int result = -1;
            RETURN_IF_ERROR(ctx->execute(&block, &result));
            DCHECK(result != -1);
            auto column = block.get_by_position(result).column;
            DCHECK(column->size() == 1);
```
now
```C++
            ColumnWithTypeAndName result;
            RETURN_IF_ERROR(ctx->execute_const_expr(result));
            DCHECK(result.column->size() == 1);
```
@Mryange Mryange requested a review from yiguolei as a code owner January 14, 2026 10:33
@Mryange
Copy link
Contributor Author

Mryange commented Jan 14, 2026

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 49.18% (30/61) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.41% (18847/35288)
Line Coverage 39.25% (174927/445651)
Region Coverage 33.91% (135409/399300)
Branch Coverage 34.85% (58585/168124)

@yiguolei
Copy link
Contributor

skip buildall

@yiguolei yiguolei merged commit 076c08b into apache:branch-4.0 Jan 15, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants