Skip to content

[enhancement](workloadgroup) print path info in workload group modification operation #59873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 17, 2026
Merged

[enhancement](workloadgroup) print path info in workload group modification operation #59873

yiguolei merged 1 commit into from
Jan 17, 2026

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Jan 14, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@yiguolei
Copy link
Contributor Author

yiguolei commented Jan 14, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 14, 2026

TPC-H: Total hot run time: 31523 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 296cd75c71421d4cfb3441399f8793875b12b903, data reload: false

------ Round 1 ----------------------------------
q1	17596	4258	4055	4055
q2	2111	349	235	235
q3	10133	1257	704	704
q4	10204	817	312	312
q5	7520	2103	1808	1808
q6	187	173	140	140
q7	920	788	645	645
q8	9260	1357	1050	1050
q9	4925	4606	4628	4606
q10	6813	1833	1435	1435
q11	491	298	283	283
q12	691	749	584	584
q13	17791	3936	3156	3156
q14	292	315	294	294
q15	608	525	520	520
q16	704	699	628	628
q17	683	808	516	516
q18	6874	6647	6478	6478
q19	1086	973	617	617
q20	390	349	249	249
q21	3072	2432	2255	2255
q22	1040	1003	953	953
Total cold run time: 103391 ms
Total hot run time: 31523 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4080	4041	4093	4041
q2	339	397	327	327
q3	2061	2566	2215	2215
q4	1288	1732	1319	1319
q5	4067	3982	4013	3982
q6	224	174	128	128
q7	1848	1794	1719	1719
q8	2827	2468	2458	2458
q9	7284	7321	7324	7321
q10	2569	2710	2387	2387
q11	559	488	488	488
q12	745	764	659	659
q13	3545	4073	3439	3439
q14	300	300	284	284
q15	549	488	522	488
q16	653	671	650	650
q17	1185	1361	1400	1361
q18	7990	7851	7972	7851
q19	908	893	856	856
q20	2007	2080	1876	1876
q21	4810	4284	4061	4061
q22	1111	1003	978	978
Total cold run time: 50949 ms
Total hot run time: 48888 ms

@doris-robot
Copy link

doris-robot commented Jan 14, 2026

TPC-DS: Total hot run time: 174240 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 296cd75c71421d4cfb3441399f8793875b12b903, data reload: false

query5	4394	601	496	496
query6	323	244	214	214
query7	4229	445	254	254
query8	326	239	235	235
query9	8736	2871	2808	2808
query10	513	355	314	314
query11	15131	15224	14843	14843
query12	169	111	111	111
query13	1265	478	353	353
query14	6029	2946	2761	2761
query14_1	2639	2630	2597	2597
query15	202	192	170	170
query16	995	496	465	465
query17	1122	694	576	576
query18	2447	443	333	333
query19	226	222	196	196
query20	120	113	115	113
query21	219	141	119	119
query22	4236	4206	4287	4206
query23	15962	15546	15569	15546
query23_1	15317	15583	15484	15484
query24	7233	1582	1172	1172
query24_1	1165	1176	1195	1176
query25	585	467	424	424
query26	1245	263	151	151
query27	2766	445	266	266
query28	4559	2160	2141	2141
query29	783	543	446	446
query30	313	241	212	212
query31	830	642	592	592
query32	83	79	73	73
query33	542	362	309	309
query34	897	874	530	530
query35	722	755	700	700
query36	894	891	884	884
query37	129	101	85	85
query38	2738	2671	2694	2671
query39	780	768	729	729
query39_1	716	732	707	707
query40	218	141	124	124
query41	73	67	69	67
query42	104	101	103	101
query43	477	456	399	399
query44	1313	726	738	726
query45	189	188	180	180
query46	817	941	556	556
query47	1483	1553	1451	1451
query48	299	319	233	233
query49	644	426	347	347
query50	604	278	203	203
query51	3729	3815	3720	3720
query52	103	106	96	96
query53	287	321	276	276
query54	306	278	271	271
query55	81	83	76	76
query56	378	314	304	304
query57	1043	1006	973	973
query58	269	255	262	255
query59	2151	2096	2162	2096
query60	339	325	314	314
query61	161	158	149	149
query62	399	379	311	311
query63	290	257	262	257
query64	4998	1295	982	982
query65	3800	3762	3757	3757
query66	1456	432	316	316
query67	16220	16087	15810	15810
query68	5560	995	696	696
query69	512	358	310	310
query70	973	833	947	833
query71	363	302	289	289
query72	5758	3388	3338	3338
query73	777	722	300	300
query74	8829	8767	8600	8600
query75	2804	2800	2432	2432
query76	3374	1061	633	633
query77	536	371	298	298
query78	9687	9785	9161	9161
query79	1493	915	558	558
query80	627	574	482	482
query81	522	263	231	231
query82	214	150	110	110
query83	266	265	239	239
query84	260	112	105	105
query85	888	519	464	464
query86	401	307	306	306
query87	2814	2842	2803	2803
query88	3600	2102	2115	2102
query89	380	346	326	326
query90	2176	162	159	159
query91	173	161	140	140
query92	92	72	67	67
query93	1700	884	516	516
query94	585	302	304	302
query95	579	342	370	342
query96	549	469	191	191
query97	2335	2410	2285	2285
query98	213	199	202	199
query99	599	569	535	535
Total cold run time: 252416 ms
Total hot run time: 174240 ms

@doris-robot
Copy link

doris-robot commented Jan 14, 2026

ClickBench: Total hot run time: 27.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 296cd75c71421d4cfb3441399f8793875b12b903, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.60	0.11	0.11
query5	0.27	0.24	0.26
query6	1.17	0.65	0.64
query7	0.04	0.02	0.03
query8	0.06	0.03	0.04
query9	0.58	0.49	0.50
query10	0.56	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.10	0.10
query13	0.60	0.58	0.58
query14	0.96	0.95	0.94
query15	0.80	0.78	0.79
query16	0.39	0.40	0.40
query17	1.04	1.07	1.08
query18	0.23	0.21	0.21
query19	1.85	1.74	1.86
query20	0.01	0.01	0.02
query21	15.47	0.27	0.13
query22	5.21	0.05	0.04
query23	15.94	0.28	0.10
query24	1.76	0.58	0.89
query25	0.10	0.06	0.08
query26	0.14	0.13	0.13
query27	0.07	0.07	0.05
query28	5.23	1.06	0.89
query29	12.52	3.92	3.13
query30	0.28	0.14	0.12
query31	2.82	0.66	0.39
query32	3.24	0.56	0.48
query33	2.97	2.99	3.06
query34	16.08	5.11	4.46
query35	4.42	4.49	4.44
query36	0.66	0.49	0.49
query37	0.11	0.06	0.07
query38	0.08	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.04	0.04
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.37 s
Total hot run time: 27.05 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 14, 2026

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.96% (18973/35826)
Line Coverage 39.00% (175772/450689)
Region Coverage 33.59% (136137/405306)
Branch Coverage 34.64% (58884/169999)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 14, 2026

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.88% (25938/35109)
Line Coverage 61.32% (276018/450105)
Region Coverage 56.19% (230258/409818)
Branch Coverage 58.10% (99222/170764)

@yiguolei
Copy link
Contributor Author

yiguolei commented Jan 14, 2026

skip check_coverage

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 14, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

PR approved by anyone and no changes requested.

mrhhsg
mrhhsg approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yiguolei yiguolei merged commit 2254b35 into apache:master Jan 17, 2026
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 17, 2026
@yiguolei
[enhancement](workloadgroup) print path info in workload group modifi…
757849b 
…cation operation (#59873)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Jan 17, 2026
Merged
yiguolei added a commit that referenced this pull request Jan 17, 2026
@github-actions @yiguolei
branch-4.0: [enhancement](workloadgroup) print path info in workload …
1148f20 
…group modification operation #59873 (#59986)

Cherry-picked from #59873

Co-authored-by: yiguolei <guolei@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yiguolei @doris-robot @hello-stephen @mrhhsg @BiteTheDDDDt