Skip to content

[fix] Add ORC filter row context #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xylaaaaa wants to merge 1 commit into
base: orc
Choose a base branch
from
Open

[fix] Add ORC filter row context #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion c++/include/orc/Reader.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,11 +385,17 @@ namespace orc {
bool getUseTightNumericVector() const;
};

struct ORCFilterContext {
uint64_t batchFirstRow;
uint64_t stripe;
uint64_t rowInStripe;
};

class ORCFilter {
public:
virtual ~ORCFilter() = default;
virtual void filter(ColumnVectorBatch& data, uint16_t* sel, uint16_t size,
void* arg = nullptr) const = 0;
const ORCFilterContext& context, void* arg = nullptr) const = 0;
};

class StringDictFilter {
Expand Down
5 changes: 4 additions & 1 deletion c++/src/Reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,10 @@ namespace orc {
// Apply filter callback to reduce number of # rows selected for decoding in the next
// TreeReaders
if (readerContext->getFilterCallback()) {
readerContext->getFilterCallback()->filter(data, sel_rowid_idx, batchSize, arg);
ORCFilterContext filterContext{firstRowOfStripe[currentStripe] + currentRowInStripe,
currentStripe, currentRowInStripe};
readerContext->getFilterCallback()->filter(data, sel_rowid_idx, batchSize, filterContext,
arg);
}
}
}
Expand Down