[Improvement-17330][K8s] Replace job watcher with informer#18358
Open
det101 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
det101
force-pushed
the
fix-17330-k8s-stale-resource-version
branch
from
746825e to
b65a890
Compare
|
ruanwenjun
reviewed
Jun 18, 2026
|
|
||
| @Override | ||
| public void onAdd(Job watchedJob) { | ||
| // ignore initial add event, same as Watcher.Action.ADDED |
| countDownLatch.countDown(); | ||
| @Override | ||
| public void onUpdate(Job oldJob, Job watchedJob) { | ||
| handleBatchJobEvent(watchedJob, taskInstanceId, taskResponse, countDownLatch); |
Member
There was a problem hiding this comment.
Remove handleBatchJobEvent method, since the method name is strategy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES
Purpose of the pull request
fix #17330
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-api clean test -Dtest=K8sTaskExecutorTest
busyboxshort task (sleep 10) succeeds end-to-endsleep 2400) does not fail withtoo old resource version([Improvement][K8s] too old resource version #17330)Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md