[Fix-18247] Fix when forceTaskSuccess is performed on the last unsuccessful workflow instance, the workflow instance cannot be reset to the Success state#18351
Open
SbloodyS wants to merge 8 commits into
Conversation
ruanwenjun
requested changes
Jun 17, 2026
ruanwenjun
reviewed
Jun 18, 2026
| definiteTaskCodeList)) { | ||
| List<Integer> failTaskList = validTaskList.stream() | ||
| .filter(instance -> instance.getState().isFailure() || instance.getState().isKill()) | ||
| .filter(instance -> instance.getState().isForceSuccess() || instance.getState().isFailure()) |
Member
There was a problem hiding this comment.
If there exists task which status is killed or paused, then we still cannot set the workflow instance to success.
A simple logic here might be to check whether all instances have succeeded.
Member
Author
There was a problem hiding this comment.
Yes. You are right. Added.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
No.
Purpose of the pull request
fix #18247
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md