Skip to content

fix(dalgorm): make DropIndexes idempotent by skipping missing indexes #9001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DoDiODev wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

fix(dalgorm): make DropIndexes idempotent by skipping missing indexes #9001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions backend/impls/dalgorm/dalgorm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,9 +452,18 @@ func (d *Dalgorm) RenameTable(oldName, newName string) errors.Error {

// DropIndexes drops indexes for specified table
func (d *Dalgorm) DropIndexes(table string, indexNames ...string) errors.Error {
migrator := d.db.Migrator()
for _, indexName := range indexNames {
err := d.db.Migrator().DropIndex(table, indexName)
if err != nil {
// Skip indexes that are not present so the operation is idempotent and
// database-neutral. GORM's DropIndex emits a bare `DROP INDEX` (without
// `IF EXISTS`), which makes PostgreSQL fail with SQLSTATE 42704 when the
// index is missing (e.g. it was already removed by an earlier column
// rewrite). Guarding with HasIndex keeps genuine errors from being
// swallowed while making repeated/partial migrations safe.
if !migrator.HasIndex(table, indexName) {
continue
}
if err := migrator.DropIndex(table, indexName); err != nil {
return d.convertGormError(err)
}
}
Expand Down