feat(theta): add compact sketch serialization#97
Closed
jonbjo wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
Member
Author
|
You are right, #77 covers this PR and more. My bad to not check existing PRs before pushing. I needed serialisation for Apache Polaris rust library since it is used for table stats in Puffin files and I implemented it earlier. As I was cleaning up the code I figured I would push this part upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add binary serialization support for Theta sketches, compatible with Apache DataSketches Java and C++ implementations.
Changes
CompactThetaSketchtype withserialize()anddeserialize()methodsThetaSketch:compact(),serialize(),deserialize()seed_hash=0format for backward compatibilityMotivation
This enables reading and writing Theta sketches in formats used by Iceberg Puffin files.
Limitations
This PR focuses on the standard compact format. Identified features not included:
toByteArrayCompressed()uses bit-packing for smaller size; not supportedThese could be added in follow-up PRs if needed.
Testing
datasketches-java