Skip to content

fix(proto): preserve empty projection when ser/de MemoryScanExec - #24087

Open
buraksenn wants to merge 2 commits into
apache:mainfrom
buraksenn:presever-empty-proj-memory-scan-exec
Open

fix(proto): preserve empty projection when ser/de MemoryScanExec#24087
buraksenn wants to merge 2 commits into
apache:mainfrom
buraksenn:presever-empty-proj-memory-scan-exec

Conversation

@buraksenn

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Empty projection is not ser/de correctly in MemoryScanExec

What changes are included in this PR?

Use same approach as FilterExec, HashJoinExec etc for projection encode/decode

Are these changes tested?

Yes, new roundtrip test roundtrip_memory_source_empty_projection, which fails on main.

Are there any user-facing changes?

No

@github-actions github-actions Bot added the proto Related to proto crate label Aug 4, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.89%. Comparing base (66c3840) to head (6e5213f).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
datafusion/proto/src/physical_plan/mod.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24087      +/-   ##
==========================================
+ Coverage   80.86%   80.89%   +0.03%     
==========================================
  Files        1101     1102       +1     
  Lines      375446   376107     +661     
  Branches   375446   376107     +661     
==========================================
+ Hits       303592   304256     +664     
+ Misses      53761    53743      -18     
- Partials    18093    18108      +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

preserve empty projection when ser/de MemoryScanExec

2 participants