PoC(CI): Introduce xtask to keep local test and CI commands in sync - #24083
Open
2010YOUY01 wants to merge 1 commit into
Open
PoC(CI): Introduce xtask to keep local test and CI commands in sync#240832010YOUY01 wants to merge 1 commit into
xtask to keep local test and CI commands in sync#240832010YOUY01 wants to merge 1 commit into
Conversation
… and `cargo test ...`
xtask to keep local test and CI run in syncxtask to keep local test and CI commands in sync
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24083 +/- ##
==========================================
- Coverage 80.87% 80.86% -0.02%
==========================================
Files 1101 1104 +3
Lines 375716 376657 +941
Branches 375716 376657 +941
==========================================
+ Hits 303874 304587 +713
- Misses 53739 53953 +214
- Partials 18103 18117 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #21048
Rationale for this change
The end goal is easy local CI reproducer like
This PR only try to encapsulate single CI step with
xtask, and hope later build towards that goal. Running test commands locally mirroring CI become easier after this PR.For example, the default test run command is:
datafusion/.github/workflows/rust.yml
Lines 324 to 335 in 26fbf4d
Now both ci and local run can be executed with
The command is a bit verbose, since it's a common pattern (see top comments at
xtask/src/main.rs) for all internal dev tools, so we might need additional domains likecargo xtask benchmark [bench-name]xtaskimplementation mechanismSee
xtask/src/main.rstop comments for details.TLDR: internal binary, no external dependencies.
xtaskv.s. shell scriptThe existing CI jobs consist of lot of similar commands, that is parameterized with features, settings, so it would be easier to implement the runner that can handle args, to make the maintenance easier.
We also want some extra functionalities, like the above
explainfeature, or more complex orchestration needed for the 'one-click local CI run' end goal.At this complexity, I find implementing it in rust is easier than shell scripts.
What changes are included in this PR?
In rust CI workflow (
rust.yml), encapsulatecargo test ...andcargo check ...family intoxtaskrunnerTo review the core changes, start from the top comments in
xtask/src/main.rsAre these changes tested?
Are there any user-facing changes?