chore: apply workspace lints to all crates - #24076
Merged
Merged
Conversation
Pure reordering, no lint is added or removed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`datafusion/proto`, `datafusion/proto-common` and `datafusion/proto-models` were the only workspace members without `[lints] workspace = true`, so the workspace lint configuration silently did not apply to them. Enabling it surfaces a handful of violations, fixed here: * `unused_qualifications`: redundant path prefixes (mostly `cargo fix`ed) * `clippy::or_fun_call`: `unwrap_or(HashMap::new())` -> `unwrap_or_default()` * `clippy::needless_pass_by_value`: one `#[expect]` on a public API, plus a crate-level exemption for the integration tests matching what the other DataFusion crates already do for their unit tests The generated protobuf modules opt out of `unused_qualifications` alongside the `clippy::all` opt-out they already had. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 4, 2026
emilk
commented
Aug 4, 2026
| uuid = "1.23" | ||
| zstd = { version = "0.13", default-features = false } | ||
|
|
||
| # Keep this list sorted alphabetically. |
Contributor
Author
There was a problem hiding this comment.
sorting makes it easier to check if a lint already has been added
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24076 +/- ##
==========================================
- Coverage 80.89% 80.89% -0.01%
==========================================
Files 1102 1102
Lines 376093 376078 -15
Branches 376093 376078 -15
==========================================
- Hits 304239 304211 -28
- Misses 53748 53757 +9
- Partials 18106 18110 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
approved these changes
Aug 4, 2026
2010YOUY01
left a comment
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Thank you. I have verified the core change (cargo.toml) manually, and have let codex checked all propagated changes, and it looks good.
Contributor
|
Thank you @emilk and @2010YOUY01 |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 4, 2026
alamb
added a commit
to apache/arrow-rs
that referenced
this pull request
Aug 4, 2026
# Which issue does this PR close? No issue in particular - Related to #10458 - Sibling PR: apache/datafusion#24076 # Rationale for this change Lint configuration is currently repeated per crate in `lib.rs`. A `[workspace.lints]` table lets us configure lints once, for every crate, and makes rolling out new lints a one-line change. Enabling more lints can also help keeping a higher code quality, reducing bugs. # What changes are included in this PR? Modeled on [egui's `Cargo.toml`](https://github.com/emilk/egui/blob/main/Cargo.toml). I started small. We can enable more lints in later PRs. # Are these changes tested? Yes, by existing CI: `cargo clippy --workspace --all-targets --all-features -- -D warnings` and the docs job (`RUSTDOCFLAGS=-Dwarnings`) both pass. Two previously-dead doc examples now actually compile and run. # Are there any user-facing changes? `parquet_variant_compute::VariantArrayIter` is now exported. It was already returned by the public `VariantArray::iter`, but was not nameable. No other API changes. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Clippychecks in CI #18467Rationale for this change
The workspace already has a
[workspace.lints]table, but it was missing from three cratesWhat changes are included in this PR?
Inheriting the workspace lints in all crates, and fixing the resulting violations
Are these changes tested?
Yes, by existing tests and CI
Are there any user-facing changes?
No