feat(functions): re-expose string builder API for concat - #24064
Open
mzabaluev wants to merge 2 commits into
Open
feat(functions): re-expose string builder API for concat#24064mzabaluev wants to merge 2 commits into
mzabaluev wants to merge 2 commits into
Conversation
The builders hidden by apache#21695 are useful for third party UDFs that want to implement their own concat functions, e.g. one that faithfully replicates the behavior of Spark's concat.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24064 +/- ##
==========================================
- Coverage 80.87% 80.87% -0.01%
==========================================
Files 1101 1101
Lines 375765 375765
Branches 375765 375765
==========================================
- Hits 303915 303905 -10
- Misses 53747 53753 +6
- Partials 18103 18107 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove a reference to a private type from the doc comment on ConcatGenericStringBuilder, which is now public. Turn the paragraph into a plain comment with a note to add it later if StringViewArrayBuilder is made public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The builders hidden by #21695 are useful for third party UDFs that want to implement their own concat functions, e.g. one that faithfully replicates the behavior of Spark's concat.
What changes are included in this PR?
Make these definitions in datafusion-funcions'
stringsmodule public:ConcatBuilder(trait)ConcatGenericStringBuilder(struct)ConcatStringBuilder,ConcatLargeStringBuilder(typedefs)ConcatStringViewBuilder(struct)ColumnarValueRef(enum)Are these changes tested?
No functionality has been changed.
Integration tests, doctests, or an example for the newly public APIs can be added on request.
Are there any user-facing changes?
The APIs listed above are made public, with existing comments.