Skip to content

chore(datasource): remove deprecated add_row_stats (Closes #23080 - partial) #23134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dodothereal wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −11
Open

chore(datasource): remove deprecated add_row_stats (Closes #23080 - partial) #23134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions datafusion/datasource/src/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ use datafusion_physical_expr::LexOrdering;
use futures::Stream;
use object_store::{ObjectMeta, path::Path};
pub use table_schema::{TableSchema, TableSchemaBuilder};
// Remove when add_row_stats is remove
use arrow::datatypes::SchemaRef;
#[expect(deprecated)]
pub use statistics::add_row_stats;
pub use statistics::compute_all_files_statistics;
use std::any::Any;
use std::pin::Pin;
Expand Down
8 changes: 0 additions & 8 deletions datafusion/datasource/src/statistics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,14 +541,6 @@ pub fn compute_all_files_statistics(
Ok((file_groups_with_stats, statistics))
}

#[deprecated(since = "47.0.0", note = "Use Statistics::add")]
pub fn add_row_stats(
file_num_rows: Precision<usize>,
num_rows: Precision<usize>,
) -> Precision<usize> {
file_num_rows.add(&num_rows)
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down