Add basic sql benchmark runner for running sql benchmarks#23052
Draft
Omega359 wants to merge 2 commits into
Draft
Add basic sql benchmark runner for running sql benchmarks#23052Omega359 wants to merge 2 commits into
Omega359 wants to merge 2 commits into
Conversation
… with either simple iterations or using criterion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Running sql benchmarks using environment variables for configuration is awkward and error prone and strictly using criterion, while statistically much better, is quite slow compared to using simple iterations.
This PR is the first version of a benchmark runner for sql benchmarks that will eventually use arguments for all benchmark configuration options.
What changes are included in this PR?
A simple benchmark runner that can list out the sql benchmarks and run a benchmark using iterations or criterion allowing for specifying a single query if desired.
Future enhancements will use arguments for benchmark configuration vs just using environment variables as well as providing help and tying this into bench.sh
Are these changes tested?
Yes. I have a script that tests all current sql benchmarks both with and without criterion. Here is an portion of it for the single clickbench benchmark:
The existing
cargo benchapproach still works the same (criterion only):Are there any user-facing changes?
No.