refactor(hash-aggr): Migrate the partial aggregation skip optimization to the new hash aggregation impl#22899
Open
2010YOUY01 wants to merge 4 commits into
Open
refactor(hash-aggr): Migrate the partial aggregation skip optimization to the new hash aggregation impl#228992010YOUY01 wants to merge 4 commits into
2010YOUY01 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #22710
Rationale for this change
See issue for the background, this PR forward ports below optimization to the rewritten hash aggregation
After this migration, the performance is back, so this PR also changes the temporary configuration
datafusion.execution.enable_migration_aggregatedefault totrue-- the new path will be used by default.Local Clickbench_partitioned result (see
benchmarks/for details), on M4 Pro MacBookWhat changes are included in this PR?
This PR is easier to read commit-by-commit.
aggregates/row_hash.rs->aggregates/utils.rsenable_migration_aggregatedefault to trueAre these changes tested?
Existing tests + new UT
Are there any user-facing changes?
No