Add benchmark_runner info and query commands#22032
Draft
Omega359 wants to merge 1 commit intoapache:mainfrom
Draft
Add benchmark_runner info and query commands#22032Omega359 wants to merge 1 commit intoapache:mainfrom
Omega359 wants to merge 1 commit intoapache:mainfrom
Conversation
920ad3c to
fa4a61e
Compare
fa4a61e to
8216ecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This continues the
benchmark_runnerCLI work by adding non-execution inspection commands for SQL benchmark suites and native benchmarks.The goal is to let users discover benchmark metadata and inspect parsed SQL without running benchmarks. This also gives SQL suite metadata a single
.suite-driven source of truth for CLI options, examples, and query file resolution.See #22001 (comment) for future planned steps.
What changes are included in this PR?
This PR adds support for:
benchmark_runner info <SUITE>benchmark_runner info <SUITE> <QUERY_ID>benchmark_runner info <NATIVE_BENCHMARK>benchmark_runner query <SUITE> <QUERY_ID>It also includes:
.suitemetadatainfoandquery-sfquery_patternsupportlistandinfoinfoandqueryoutputBenchmark execution is intentionally not included in this PR. The
runcommand is left for the next stacked PR.Are these changes tested?
Yes. This PR adds and updates tests for:
query_patternhandlinginfooutput for suites and individual queriesqueryoutput grouped by benchmark directiveAre there any user-facing changes?
Yes. The benchmark_runner binary gains new inspection commands:
• info
• query
These commands are additive and do not change public Rust APIs.
Use of AI
This code was partially written by Codex but edited, reviewed and tested by @Omega359