Skip to content

Fix elapsed_compute metric for Parquet DataSourceExec #20767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ernestprovo23 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

Fix elapsed_compute metric for Parquet DataSourceExec #20767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions datafusion/datasource-parquet/src/opener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ use datafusion_physical_expr_common::physical_expr::{
PhysicalExpr, is_dynamic_physical_expr,
};
use datafusion_physical_plan::metrics::{
Count, ExecutionPlanMetricsSet, Gauge, MetricBuilder, PruningMetrics,
BaselineMetrics, Count, ExecutionPlanMetricsSet, Gauge, MetricBuilder, PruningMetrics,
};
use datafusion_pruning::{FilePruner, PruningPredicate, build_pruning_predicate};

Expand Down Expand Up @@ -191,6 +191,7 @@ impl FileOpener for ParquetOpener {
let file_name = file_location.to_string();
let file_metrics =
ParquetFileMetrics::new(self.partition_index, &file_name, &self.metrics);
let baseline_metrics = BaselineMetrics::new(&self.metrics, self.partition_index);

let metadata_size_hint = partitioned_file
.metadata_size_hint
Expand Down Expand Up @@ -631,7 +632,8 @@ impl FileOpener for ParquetOpener {
let projector = projection.make_projector(&stream_schema)?;

let stream = stream.map_err(DataFusionError::from).map(move |b| {
b.and_then(|mut b| {
let mut timer = baseline_metrics.elapsed_compute().timer();
let result = b.and_then(|mut b| {
copy_arrow_reader_metrics(
&arrow_reader_metrics,
&predicate_cache_inner_records,
Expand Down Expand Up @@ -659,7 +661,9 @@ impl FileOpener for ParquetOpener {
} else {
Ok(b)
}
})
});
timer.stop();
result
});

// ----------------------------------------------------------------------
Expand Down