Attach diagnostic information for duplicate table name error#20720
Open
buraksenn wants to merge 4 commits intoapache:mainfrom
Open
Attach diagnostic information for duplicate table name error#20720buraksenn wants to merge 4 commits intoapache:mainfrom
buraksenn wants to merge 4 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Diagnosticto "duplicate table name" error #14436Rationale for this change
This is part of #14429 epic to add diagnostic to more errors.
What changes are included in this PR?
This PR adds optional span with the CTE and uses those spans to best effort attach diagnostics
Are these changes tested?
Are there any user-facing changes?
Yes users can call diagnostic methods to get detailed information about errors