Do not reset HashJoinExec state when calling HashJoinExec::with_projection#20340
Closed
alamb wants to merge 2 commits intoapache:mainfrom
Closed
Do not reset HashJoinExec state when calling HashJoinExec::with_projection#20340alamb wants to merge 2 commits intoapache:mainfrom
HashJoinExec state when calling HashJoinExec::with_projection#20340alamb wants to merge 2 commits intoapache:mainfrom
Conversation
alamb
changed the title
alamb
commented
Feb 13, 2026
| .with_projection_ref(projection) | ||
| .build() | ||
|
|
||
| let cache = HashJoinExec::compute_properties( |
Contributor
Author
There was a problem hiding this comment.
the point here is to be explcity (and more verbose) rather than resetting the state
alamb
changed the title
HashJoinExec state when calling HashJoinExec::with_projection
Contributor
Contributor
Author
|
I think #20276 is better so let's go with that one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ExecutionPlans less costly) #19893 from @askaltRationale for this change
@2010YOUY01 noted in https://github.com/apache/datafusion/pull/19893/changes#r2787434025 that the change to
HashJoinExec::with_projectionresulting in non obviously resetting the plan state (like dynamic filters). This could potentially lead to bugs in the future so let's be explicitWhat changes are included in this PR?
Remove use of HashJoinExecBuilder
Are these changes tested?
Yes, by existing CI
Are there any user-facing changes?
No