Reject invalid numeric underscore separators - #2426
Draft
fyrsta7 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2421 by rejecting invalid numeric underscore separators for dialects that support underscores in numeric literals.
Details
Numeric separators should appear between digits. This keeps valid literals such as
10_000and1_000.123_456, while rejecting trailing, consecutive, and decimal-point-adjacent underscores such as10_00_,10___0,1_000.123_, and1._000.The change adds coverage at both the tokenizer and parser test levels.
Validation
git diff --checkcargo fmt --all --checkcargo test tokenize_numeric_literal_underscore -- --nocapturecargo test parse_numeric_literal_underscore --test sqlparser_common -- --nocapturecargo test