Postgres regression 7b#2301
Conversation
| /// XML content fragment. | ||
| /// | ||
| /// [PostgreSQL](https://www.postgresql.org/docs/current/functions-xml.html#FUNCTIONS-PRODUCING-XML-XMLCONCAT) | ||
| XmlConcat(Vec<Expr>), |
There was a problem hiding this comment.
xmlconcat looks like a regular function syntax wise, is the parser unable to parse it today?
There was a problem hiding this comment.
It can be parsed as a function, I added it to the enum nevertheless for easy of use, for the same reason that other functions like CEIL for instance appear there. Of course, open to discussion whether it is worth it.
There was a problem hiding this comment.
ah I see, I think we should keep the parsing as is that it gets represented as a regular function vs making it a special case
There was a problem hiding this comment.
Ok so, just to be clear, I should close this particular PR and leave this as-is?
There was a problem hiding this comment.
Yeah we can close this and have the current behavior as is
Expr::XmlConcat(Vec<Expr>)variant withDisplayandSpannedimplementations for PostgreSQL'sXMLCONCAT(xml[, ...])functionmaybe_parse_xml_functiondispatcher in the parser, hooked at the top ofparse_function, which routes XML function names to dedicated AST nodes on dialects wheresupports_xml_expressions()is truexmlconcat(...)on PostgreSQL and Generic dialects takes the new path — all other dialects and qualified/quoted names fall through to the normal function-call parserThis is the second PR in a chain splitting #2252 (XML function support) into reviewable units. Builds on #2299 which introduced the
supports_xml_expressions()dialect method.