fix: remove todo from indexed field key - #1667
Open
BharatDeva wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #552.
Rationale for this change
Issue #552 tracks replacing remaining
todo!()calls with explicit errors. The only remainingtodo!()was inPyGetIndexedField::key, where unsupported list-index and list-range field access could panic instead of returning a Python error.What changes are included in this PR?
This updates
PyGetIndexedField::keyto keep returning the struct field key forNamedStructField, and to return the existing unsupported-variant error for list index and list range access.Are there any user-facing changes?
No API change is intended. This only replaces an internal panic path with an explicit Python error for unsupported field access forms.
Testing
cargo fmt --checkwsl bash -lc "cd /mnt/c/Users/bhara/OneDrive/Desktop/Python/datafusion-python && cargo check -p datafusion-python"rg -n "todo!\\(" crates/core/src -g "*.rs"returned no matches