chore: run Spark 3.4 tests with native_datafusion scan#3722
Open
andygrove wants to merge 5 commits intoapache:mainfrom
Open
chore: run Spark 3.4 tests with native_datafusion scan#3722andygrove wants to merge 5 commits intoapache:mainfrom
native_datafusion scan#3722andygrove wants to merge 5 commits intoapache:mainfrom
Conversation
Tag tests with IgnoreCometNativeDataFusion and IgnoreCometNativeScan to match tags already applied in the 3.5.8 diff, plus 3 tests that are specific to Spark 3.4.
…diff Remove imports of IgnoreCometNativeDataFusion in DynamicPartitionPruningSuite and FileBasedDataSourceSuite since both files are in the org.apache.spark.sql package where IgnoreCometNativeDataFusion is defined, making the import redundant and causing "permanently hidden" compilation errors.
… diff The test override in SQLTestUtils checked DisableAdaptiveExecution first, so tests with both DisableAdaptiveExecution and IgnoreCometNativeDataFusion tags (like "static scan metrics") would enter the DAE branch and never check the ignore tag. Reorder to match the 3.5.8 diff: check Comet skip tags first with early returns, then handle DisableAdaptiveExecution.
andygrove
changed the title
native_datafusion scan [WIP]native_datafusion scan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A - CI enablement
Rationale for this change
The
native_datafusionSpark SQL tests were already running for Spark 3.5 but not for Spark 3.4. Adding 3.4 coverage revealed test failures that need to be skipped with the appropriate ignore tags.What changes are included in this PR?
native_datafusionCI workflowdev/diffs/3.4.3.diffto tag failing tests withIgnoreCometNativeDataFusionandIgnoreCometNativeScan, matching tags already applied in the 3.5.8 diff plus 3 tests specific to Spark 3.4:How are these changes tested?
By running the Spark SQL
native_datafusiontests in CI for Spark 3.4.3.