Skip to content

fix: Use the loaded Comet extension too (Spark 3.5.8)#3707

Open
martin-g wants to merge 2 commits intoapache:mainfrom
martin-g:extensions-fix
Open

fix: Use the loaded Comet extension too (Spark 3.5.8)#3707
martin-g wants to merge 2 commits intoapache:mainfrom
martin-g:extensions-fix

Conversation

@martin-g
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

In the diff for Spark 3.5.8 variable extensionClassNames is initialized with the items of extensionConfClassNames and loadCometExtension(sparkContext) but then it is not used.

The diff for 3.4.3 does use it:

+ extensionClassNames.foreach { extensionConfClassName =>

What changes are included in this PR?

Iterate of the items of extensionClassNames.

How are these changes tested?

Run current test suite

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g changed the title Use the loaded Comet extension too fix: Use the loaded Comet extension too Mar 15, 2026
@martin-g martin-g changed the title fix: Use the loaded Comet extension too fix: Use the loaded Comet extension too (Spark 3.5.8) Mar 15, 2026
Copy link
Contributor

@coderfender coderfender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthchandra
Copy link
Contributor

nice catch @martin-g. There are CI failures though.

@martin-g martin-g closed this Mar 18, 2026
@martin-g martin-g reopened this Mar 18, 2026
@martin-g
Copy link
Member Author

Right!
The error is:


2026-03-18T09:55:23.5306977Z [info] - inject columnar AQE on *** FAILED *** (192 milliseconds)
2026-03-18T09:55:23.5309268Z [info]   java.lang.ClassCastException: class org.apache.spark.sql.catalyst.expressions.BoundReference cannot be cast to class org.apache.spark.sql.ColumnarExpression (org.apache.spark.sql.catalyst.expressions.BoundReference and org.apache.spark.sql.ColumnarExpression are in unnamed module of loader 'app')
2026-03-18T09:55:23.5312093Z [info]   at org.apache.spark.sql.BrokenColumnarAdd.withNewChildrenInternal(SparkSessionExtensionSuite.scala:927)
2026-03-18T09:55:23.5313407Z [info]   at org.apache.spark.sql.BrokenColumnarAdd.withNewChildrenInternal(SparkSessionExtensionSuite.scala:870)
...

@martin-g
Copy link
Member Author

It seems to be a known problem: #1197

@martin-g
Copy link
Member Author

martin-g commented Mar 18, 2026

Previously those tests were excluded for Comet - coderfender@24ee32e#diff-7917dac18d23e41523ceb1a298411e79bbf99d9349f885ac2c6c4ad81766265eR983-R984
Should I exclude them again or dive deeper and debug/fix them ?

Commit that removed the exclusion: andygrove@adcfce4

@parthchandra
Copy link
Contributor

Previously those tests were excluded for Comet - coderfender@24ee32e#diff-7917dac18d23e41523ceb1a298411e79bbf99d9349f885ac2c6c4ad81766265eR983-R984 Should I exclude them again or dive deeper and debug/fix them ?

Commit that removed the exclusion: andygrove@adcfce4

We can exclude them for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants