experiment: what tests still fail with native_datafusion scan#3682
Draft
andygrove wants to merge 4 commits intoapache:mainfrom
Draft
experiment: what tests still fail with native_datafusion scan#3682andygrove wants to merge 4 commits intoapache:mainfrom
andygrove wants to merge 4 commits intoapache:mainfrom
Conversation
In auto scan mode, try native_datafusion scan first and fall back to native_iceberg_compat when native_datafusion is not supported (e.g., when COMET_EXEC_ENABLED is disabled, or DPP is used).
- Add detection for case-insensitive duplicate field names in CometScanRule, falling back to native_iceberg_compat when native_datafusion would produce different error messages than Spark. - Fix schema evolution test to account for auto mode now preferring native_datafusion, which always handles type promotion. The metrics test failures (output_rows=0, filter pushdown=0) are pre-existing on main and not caused by this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?