feat: Support left expression#3206
Merged
andygrove merged 6 commits intoapache:mainfrom Jan 22, 2026
Merged
Conversation
Member
|
@Shekharrajak can you run |
andygrove
approved these changes
Jan 16, 2026
Member
andygrove
left a comment
There was a problem hiding this comment.
LGTM pending CI. Thanks @Shekharrajak
Member
|
@Shekharrajak could you take a look at the CI failures? |
Contributor
Author
Updated configs.md now the checks should succeed. Please trigger the workflow |
Moved Left.enabled config entry to come after LastDay.enabled to maintain alphabetical ordering in the expression configs table.
Contributor
Author
|
Looks like order was not correct last time. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
============================================
+ Coverage 56.12% 59.99% +3.86%
- Complexity 976 1418 +442
============================================
Files 119 170 +51
Lines 11743 15793 +4050
Branches 2251 2610 +359
============================================
+ Hits 6591 9475 +2884
- Misses 4012 4998 +986
- Partials 1140 1320 +180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Checks are looking fine now. |
Member
|
Thanks again @Shekharrajak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3181
Rationale for this change
Enable native execution for Spark's
LEFT(str, len)function to improve query performance by avoiding JVM fallback.What changes are included in this PR?
CometLeftserializer that transformsLEFT(str, len)toSubstring(str, 1, len)protobufLeftexpression inQueryPlanSerdestring expressions mapHow are these changes tested?
Added 4 test suites in
CometExpressionSuite:SUBSTRING(str, 1, len)