Change Navigator.connection types#144
Conversation
|
I tried to run the tests with However, given that this is a TypeScript only issue, I'm not sure it'd do anything, even if the fix introduces problems, unless said file included configuration for the eslint-typescript plugin. Nevertheless, i'd be happy to run further tests if needed |
|
Thanks for the contribution and for taking the time to address the TypeScript issue. After review, we’re going to close this PR for now. The proposed typings change introduces API mismatches with this plugin’s actual runtime behavior:
So while this does address the original TS compatibility report, it also creates new type-accuracy problems. Thanks again for your work and for raising this. |
Platforms affected
All typescript projects
Motivation and Context
Fixes "Wrong typing for Connection" (#143)
Description
Adds
dispatchEvent()toNavigator.connectionChange
Connection.typefrom string toConnectionTypeTesting
Compilating after the changes
Checklist
(platform)if this change only applies to one platform (e.g.(android))