Skip to content

fix(ios): reset pending state after stop call - #971

Open
GitToTheHub wants to merge 1 commit into
masterfrom
pr-ios-reset-pending-state-on-stop
Open

fix(ios): reset pending state after stop call#971
GitToTheHub wants to merge 1 commit into
masterfrom
pr-ios-reset-pending-state-on-stop

Conversation

@GitToTheHub

@GitToTheHub GitToTheHub commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Platforms affected

iOS

Motivation and Context

Follow up of PR #873.

@erisu noticed after PR #873 was merged, if there should be any cleanup procedures after stop was called. For example, on Android, when takePicture is executed this.imageUri is set and gets not cleared. PR #970 fixes this for Android. On iOS no files need to be cleaned up when stop is called, for this camera.cleanup is intended. But location updates will be cancelled, if they are used, and also the temporary metadata variable.

Description

  • stop and release location updates during stop cleanup
  • Defensive clear of temporary metadata variable
  • reuse the same cleanup path whether a picker is presented or not
  • no files need to be cleaned up. These are intended to be removed via cleanup call.

Generated-By: GPT-5.3-Codex

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- stop and release location updates during stop cleanup
- reuse the same cleanup path whether a picker is presented or not
- no files need to be cleaned up. These are intended to be removed via `cleanup` call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant