fix(ios): reset pending state after stop call - #971
Open
GitToTheHub wants to merge 1 commit into
Open
Conversation
- stop and release location updates during stop cleanup - reuse the same cleanup path whether a picker is presented or not - no files need to be cleaned up. These are intended to be removed via `cleanup` call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Follow up of PR #873.
@erisu noticed after PR #873 was merged, if there should be any cleanup procedures after stop was called. For example, on Android, when takePicture is executed this.imageUri is set and gets not cleared. PR #970 fixes this for Android. On iOS no files need to be cleaned up when
stopis called, for this camera.cleanup is intended. But location updates will be cancelled, if they are used, and also the temporarymetadatavariable.Description
metadatavariablecleanupcall.Generated-By: GPT-5.3-Codex
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))