Skip to content

fix: simplify edge-to-edge preference logic in CordovaActivity and SystemBarPlugin#1902

Open
seamlink-aalves wants to merge 1 commit intoapache:masterfrom
seamlink-dev:master
Open

fix: simplify edge-to-edge preference logic in CordovaActivity and SystemBarPlugin#1902
seamlink-aalves wants to merge 1 commit intoapache:masterfrom
seamlink-dev:master

Conversation

@seamlink-aalves
Copy link

Simplify edge-to-edge preference logic

Platforms affected

Android

Motivation and Context

The motivation and context was described here: apache/cordova-discuss#114

When having cordova android in Edge To Edge the app does not extend to the full height of the device in version bellow Android 15. This change allows the app to behave the same way it was possible to do with the statusbar plugin preference StatusBarOverlaysWebView given that this stopped having any effect in cordova-android 15.

Description

This PR removes the limitation for Android version <15 when preference AndroidEdgeToEdge is true.

Testing

Tested in Android 12, 13 and 16

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant