fix: simplify edge-to-edge preference logic in CordovaActivity and SystemBarPlugin#1902
Open
seamlink-aalves wants to merge 1 commit intoapache:masterfrom
Open
fix: simplify edge-to-edge preference logic in CordovaActivity and SystemBarPlugin#1902seamlink-aalves wants to merge 1 commit intoapache:masterfrom
seamlink-aalves wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify edge-to-edge preference logic
Platforms affected
Android
Motivation and Context
The motivation and context was described here: apache/cordova-discuss#114
When having cordova android in Edge To Edge the app does not extend to the full height of the device in version bellow Android 15. This change allows the app to behave the same way it was possible to do with the statusbar plugin preference
StatusBarOverlaysWebViewgiven that this stopped having any effect in cordova-android 15.Description
This PR removes the limitation for Android version <15 when preference
AndroidEdgeToEdgeis true.Testing
Tested in Android 12, 13 and 16
Checklist
(platform)if this change only applies to one platform (e.g.(android))