Skip to content

Remove unused private Method PermissionHelper.deliverPermissionResult#1858

Merged
GitToTheHub merged 4 commits intoapache:masterfrom
GitToTheHub:pr-remove-unused-method-deliverpermissionresult-in-permissionhelper
Apr 20, 2026
Merged

Remove unused private Method PermissionHelper.deliverPermissionResult#1858
GitToTheHub merged 4 commits intoapache:masterfrom
GitToTheHub:pr-remove-unused-method-deliverpermissionresult-in-permissionhelper

Conversation

@GitToTheHub
Copy link
Copy Markdown
Contributor

  • The method deliverPermissionResult is private and nowhere used. Because it's private, it cannot be called from outside and cannot be overwritten and is safe to remove.

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- The method deliverPermissionResult is private and nowhere used. Because it's private, it cannot be called from outside and cannot be overwritten and is safe to remove.
@GitToTheHub GitToTheHub changed the title Remove unused private Method PermissionHelper.deliverPermissionResult Remove unused private Method PermissionHelper.deliverPermissionResult Oct 28, 2025
- The method deliverPermissionResult is private and nowhere used. Because it's private, it cannot be called from outside and cannot be overwritten and is safe to remove.
…issionhelper' of https://github.com/GitToTheHub/cordova-android into pr-remove-unused-method-deliverpermissionresult-in-permissionhelper
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.43%. Comparing base (190076b) to head (70906f2).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1858   +/-   ##
=======================================
  Coverage   61.43%   61.43%           
=======================================
  Files          24       24           
  Lines        4922     4922           
=======================================
  Hits         3024     3024           
  Misses       1898     1898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitToTheHub GitToTheHub merged commit 9c3d826 into apache:master Apr 20, 2026
10 checks passed
@GitToTheHub GitToTheHub deleted the pr-remove-unused-method-deliverpermissionresult-in-permissionhelper branch April 20, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants