Add SFTP password authentication tests for Commons VFS2#754
Open
VaishKumbhar wants to merge 1 commit intoapache:masterfrom
Open
Add SFTP password authentication tests for Commons VFS2#754VaishKumbhar wants to merge 1 commit intoapache:masterfrom
VaishKumbhar wants to merge 1 commit intoapache:masterfrom
Conversation
garydgregory
requested changes
Mar 27, 2026
| * (the default DSA key generation is disabled on modern JDKs). | ||
| * </p> | ||
| */ | ||
| @TestMethodOrder(MethodOrderer.OrderAnnotation.class) |
Member
There was a problem hiding this comment.
Hello @VaishKumbhar
Thank you for the PR.
Why should the order matter? Tests should be able to be run independently unless there is a bug causing side effects.
| }, "Expected FileSystemException when accessing a resource with wrong credentials"); | ||
| } | ||
|
|
||
| // ============================ |
Member
There was a problem hiding this comment.
Please remove this comment, it doesn't document anything helpful IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
SftpPasswordAuthTest— new test class that verify SFTP password authentication viaStaticUserAuthenticatorin Commons VFS2.Why
There is no dedicated test for SFTP password-based authentication. The existing
SftpProviderTestrelies onSftpTestServerHelperwhich acceptsusername == passwordand also allowsUserAuthNone, so it does not specifically validate thatStaticUserAuthenticatorcredentials are correctly propagated through the VFS2 SFTP provider.How
PasswordAuthenticatorthat only accepts a specific username/password pair.FileSystemException.Test summary
testResolveFiletestResolveFoldertestResolveFolderWithTrailingSlashtestWrongCredentialsThrowsExceptionFileSystemExceptionis thrown