throw IllegalArgumentException for trailing whitespace in ExtendedMessageFormat argument index#750
Open
dxbjavid wants to merge 1 commit into
Open
throw IllegalArgumentException for trailing whitespace in ExtendedMessageFormat argument index#750dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
…sageformat argument index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unhandled StringIndexOutOfBoundsException on a trailing-whitespace argument index
Reading through readArgumentIndex I noticed that once it has accumulated a digit and then meets whitespace, it calls seekNonWs and immediately does pattern.charAt(pos.getIndex()) again. If that whitespace runs to the end of the pattern the index now equals the length, so a pattern like "{0 " throws StringIndexOutOfBoundsException straight out of the constructor, whereas every other unterminated element ("{0", "{0,number ") reports the documented IllegalArgumentException. I broke out of the loop when the skip reaches the end so it falls through to the existing unterminated-element error. Added a test for the "{0 " case.