validate direction number degree in SobolSequenceGenerator stream parser#325
Open
dxbjavid wants to merge 2 commits into
Open
validate direction number degree in SobolSequenceGenerator stream parser#325dxbjavid wants to merge 2 commits into
dxbjavid wants to merge 2 commits into
Conversation
Contributor
|
Thanks for the bug fix. Can you add a unit test that fails without the patch. Thank you. |
Contributor
Author
|
Added testConstructorDegreeTooLarge. It feeds a stream with degree s=60 (BITS is 52), which hits a raw ArrayIndexOutOfBoundsException without the patch and now gives MathParseException. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SobolSequenceGenerator.initFromStream reads a per-dimension degree
sfrom the direction-number stream passed to the publicSobolSequenceGenerator(int, InputStream)constructor, then allocatesnew int[s + 1]and writesdirection[d][1..s]even though eachdirection[d]holds onlyBITS + 1entries. A line withs > BITSthrows a raw ArrayIndexOutOfBoundsException ands < 1throws NegativeArraySizeException, instead of the MathParseException this parser uses for every other malformed line. Reject out-of-rangesbefore the allocation so bad input maps to MathParseException like the surrounding token parsing.