Skip to content

Improve Javadoc for StringUtils.isBlank (closes apache/commons-lang#1…#1618

Closed
NoctisSolvane wants to merge 3 commits intoapache:masterfrom
NoctisSolvane:update-javadoc-isblank-1234
Closed

Improve Javadoc for StringUtils.isBlank (closes apache/commons-lang#1…#1618
NoctisSolvane wants to merge 3 commits intoapache:masterfrom
NoctisSolvane:update-javadoc-isblank-1234

Conversation

@NoctisSolvane
Copy link
Copy Markdown

Improved Javadoc for 'isBlank' method:

  • Added clearer description
  • Included examples
  • Added @SInCE tag
  • Used proper formatting

Closes #1234

Copy link
Copy Markdown
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 not needed, it looks like change for the sake of change. Since tag now loose history.

…t needed while mantaining the other changes
@NoctisSolvane
Copy link
Copy Markdown
Author

-1 not needed, it looks like change for the sake of change. Since tag now loose history.
Thank you for reviewing my changes.
You are right - the @SInCE tag could confuse history and wasn't necessary. I removed it.
Updated the PR with just the improved description, formatting and examples.
Happy to make any other adjustments. Thanks again.

Copy link
Copy Markdown
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 the changes are even worse, this is change for the sake of change.
I will close this PR unless you can show semantic changes without messing up the formatting.

@NoctisSolvane
Copy link
Copy Markdown
Author

NoctisSolvane commented Mar 24, 2026

-1 the changes are even worse, this is change for the sake of change. I will close this PR unless you can show semantic changes without messing up the formatting.

Thank you for the honest feedback.

I understand now that my changes altered the formatting style too much and added unnecessary content. I will revert to a more minimal improvement that only explains the existing description without changing the original structure too much.

I will push the updated version shortly. If the changes aren't worth it, you are free to close the PR - I genuinely appreciate the opportunity to learn.

@garydgregory
Copy link
Copy Markdown
Member

Closing: No further changes submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants