Preserve interrupt status when wrapping InterruptedException#1594
Closed
sohamgulame wants to merge 2 commits intoapache:masterfrom
Closed
Preserve interrupt status when wrapping InterruptedException#1594sohamgulame wants to merge 2 commits intoapache:masterfrom
sohamgulame wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
-1: Please don't duplicate someone else's work in progress #1590 AND mix multiple unrelated topics in one PR. Closing. |
Author
|
Where i get the issues that are not in progress or not submitted |
Member
|
Hello @sohamgulame |
Author
|
Thanks for the feedback — understood. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UncheckedFutureImpl currently clears the thread interrupt status when catching
InterruptedException and wrapping it in UncheckedInterruptedException.
This PR restores the interrupt status by calling Thread.currentThread().interrupt()
before throwing the unchecked exception, in accordance with Java concurrency best
practices.
A unit test has been added to verify that the interrupt status is preserved.
All tests pass locally with the Maven build.