Skip to content

StringUtils.abbreviate(String, String, int) contract violations #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 6 commits into from
Feb 12, 2026
Merged

StringUtils.abbreviate(String, String, int) contract violations #1572

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69df22c
add unit tests showing mishandling of null abbrevMarker
ThrawnCA Jan 17, 2026
1ca5aeb
fix handling of null abbrevMarker
ThrawnCA Jan 17, 2026
45a2f60
add unit tests showing 'abbreviate' contract violations
ThrawnCA Jan 19, 2026
c7f79c7
Merge branch 'master' of https://github.com/apache/commons-lang into …
ThrawnCA Jan 19, 2026
fab93ea
remove surplus blank lines from tests
ThrawnCA Jan 19, 2026
0ee25ea
fix StringUtils.abbreviate for short strings
ThrawnCA Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/test/java/org/apache/commons/lang3/StringUtilsAbbreviateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ void testAbbreviate_StringIntInt() {
assertAbbreviateWithOffset("...ijklmno", 15, 10);
assertAbbreviateWithOffset("...ijklmno", 16, 10);
assertAbbreviateWithOffset("...ijklmno", Integer.MAX_VALUE, 10);

Copy link
Copy Markdown
Member

@garydgregory garydgregory Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for extra blank lines, you have // comments.

// abbreviating a shorter string allows maxWidth < 7
assertEquals("...efg", StringUtils.abbreviate("abcdefg", 5, 6));
}

@Test
Expand Down Expand Up @@ -163,6 +166,10 @@ void testAbbreviate_StringStringIntInt() {
assertAbbreviateWithAbbrevMarkerAndOffset("999ijklmno", "999", 15, 10);
assertAbbreviateWithAbbrevMarkerAndOffset("_ghijklmno", "_", 16, 10);
assertAbbreviateWithAbbrevMarkerAndOffset("+ghijklmno", "+", Integer.MAX_VALUE, 10);

// abbreviating a shorter string allows maxWidth < abbrevMarker.length * 2 + 1
assertEquals("..de", StringUtils.abbreviate("abcde", "..", 4, 4));
assertEquals("....fg", StringUtils.abbreviate("abcdefg", "....", 5, 6));
}

// Fixed LANG-1463
Expand Down
Loading