IO-639: Fixed ReversedLinesFileReader does not read first line if its empty #829
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishorMore-2005
force-pushed
the
branch
branch
from
c2bbfe7 to
17d0bc0
Compare
KishorMore-2005
force-pushed
the
branch
branch
from
17d0bc0 to
71349c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early return: Handle leftOver immediately when chunk is exhausted
Mark empty line: Remember empty line exists before leading \n
Immediate return: Don't delay first line in last chunk
Check null: Don't overwrite existing line with leftOver