[CONFIGURATION-857] Preserve duplicate non-String scalar values in flatten()#645
Merged
garydgregory merged 7 commits intoJul 15, 2026
Conversation
garydgregory
changed the title
There was a problem hiding this comment.
Pull request overview
This PR addresses CONFIGURATION-857 by adjusting list-delimiter flattening so duplicate non-String scalar values are preserved and cycle detection only skips true back-references on the active recursion path, rather than globally de-duplicating.
Changes:
- Updates
AbstractListDelimiterHandler.flatten()to preserve duplicate non-String scalar values and to treat recursion tracking as path-scoped. - Extends regression coverage for typed
getList(Class, key)conversions with duplicate values (including non-String scalars). - Updates compression/cycle regression tests to reflect the new (non-global) cycle detection behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/apache/commons/configuration2/convert/AbstractListDelimiterHandler.java | Updates flattening and recursion/container detection behavior to preserve duplicates and adjust cycle detection. |
| src/test/java/org/apache/commons/configuration2/TestAbstractConfigurationBasicFeatures.java | Adds a typed getList() regression test ensuring duplicates are preserved across multiple scalar types. |
| src/test/java/org/apache/commons/configuration2/TestPropertiesConfiguration.java | Updates cycle/compression regression expectations to match the new recursion-path-based flatten semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
garydgregory
requested changes
Jul 14, 2026
garydgregory
left a comment
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hello @mgalbis
Thank you for the PR. Please review the copilot comment and my comments as well.
…entralize cycle checks for recursive containers, and keep scalar values outside cycle detection
garydgregory
added a commit
that referenced
this pull request
Jul 15, 2026
Member
|
Thank you @mgalbis , merged 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CONFIGURATION-857.
Preserves duplicate scalar values and changes cycle detection to track only containers in the current recursion path. This skips actual back-references while allowing unrelated repeated containers and nested copies to be flattened normally.