reject trailing characters in DecimalLocaleConverter.parse#399
Open
rootvector2 wants to merge 1 commit into
Open
reject trailing characters in DecimalLocaleConverter.parse#399rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
DecimalFormat.parse(String) stops at the first unparsable character and discards the rest, so numeric locale conversion accepted trailing input. Parse with a ParsePosition and require the whole string to be consumed, matching DateLocaleConverter and NumberConverter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DecimalLocaleConverter.parsecallsDecimalFormat.parse(String), which stops at the first character it cannot read and silently drops the rest, so a locale numeric conversion of123abcreturns123and42 OR 1=1returns42. Every numeric locale converter (Byte/Short/Integer/Long/Float/Double/BigDecimal/BigInteger) routes through this one method, while the siblingDateLocaleConverterand the non-localeNumberConverteralready reject leftover input with aParsePositioncheck. Found by comparing the locale number parsers againstDateLocaleConverter; switched to that same check so the whole string must be consumed.mvn; that'smvnon the command line by itself.