Skip to content

Refactoring retention of backup schedules #11223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sureshanaparti merged 5 commits into from
Jul 30, 2025

change validation before casting

2224342
Select commit
Loading
Failed to load commit list.
Merged

Refactoring retention of backup schedules #11223

change validation before casting
2224342
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 30, 2025 in 0s

17.17% (+0.42%) compared to 6d5cefd

View this Pull Request on Codecov

17.17% (+0.42%) compared to 6d5cefd

Details

Codecov Report

❌ Patch coverage is 70.45455% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.17%. Comparing base (6d5cefd) to head (2224342).
⚠️ Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/dao/BackupDaoImpl.java 0.00% 9 Missing ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java 89.70% 3 Missing and 4 partials ⚠️
...in/java/org/apache/cloudstack/backup/BackupVO.java 0.00% 6 Missing ⚠️
...org/apache/cloudstack/backup/BackupScheduleVO.java 0.00% 3 Missing ⚠️
...stack/api/command/user/backup/CreateBackupCmd.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11223      +/-   ##
============================================
+ Coverage     16.74%   17.17%   +0.42%     
- Complexity    14065    15010     +945     
============================================
  Files          5724     5869     +145     
  Lines        507787   521689   +13902     
  Branches      61733    63504    +1771     
============================================
+ Hits          85046    89611    +4565     
- Misses       413258   422019    +8761     
- Partials       9483    10059     +576

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov