Skip to content

Conversation

@MisterRaindrop
Copy link
Collaborator

@MisterRaindrop MisterRaindrop commented Jan 26, 2026


Change logs

  1. Based on cloudberry-pxf/fdw, adapt the cloudberry code.
  2. Add regress tests.
  3. Remove pg<14 code
  4. Disable some fdw test, better tests in the future

Contributor's checklist

Here are some reminders before you submit your pull request:

  • Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
  • Learn the code contribution and doc contribution guides for better collaboration.
  • List your communications in the GitHub Issues or Discussions (if has or needed).
  • Feel free to ask for the cloudberrydb team to help review and approve.

Copy link
Collaborator

@ostinru ostinru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to support PG_VERSION_NUM < 140000 ?

@ostinru
Copy link
Collaborator

ostinru commented Jan 26, 2026

Run automation tests with FDW[1] - works pretty good:

Test Group Status Passed Failed Skipped Total
gpdb_fdw ❌ FAIL 160 1 203 364
gpdb ✅ PASS 364 0 0 364

A lot of tests SKIPPED because they are marked as @FailsWithFDW/@SkipForFDW. One test failed - but it seems to be flap.

In order to run automation test with FDW 2 things should be done:

  1. use pxf_fdw from cloudberry-pxf: ostinru@26ca67c
  2. pass USE_FDW=true to make - ostinru@737101f

Next 2-5 weeks I will have time to test cloudberry-pxf thoroughly.

[1] https://github.com/ostinru/cloudberry-pxf/actions/runs/21360130801/job/61477882099

@ostinru
Copy link
Collaborator

ostinru commented Jan 27, 2026

I have changed my mind :D

It seems that A LOT of tests skipped, and pxf_fdw is not production ready yet. So, we should have a way to disable it during make install: ostinru@3bb70ca (copy-paster from pxf-6.10.1)

PS: Same test failed in your case as well. I will suggest to skip it (ostinru@b93e889 ). I will have a time next several weeks to test it better.

@tuhaihe tuhaihe merged commit e991beb into apache:main Jan 28, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants