[CELEBORN-2351] Partition file sorting should only be paused for PUSH_AND_REPLICATE_PAUSED#3720
Open
s0nskar wants to merge 1 commit into
Open
[CELEBORN-2351] Partition file sorting should only be paused for PUSH_AND_REPLICATE_PAUSED#3720s0nskar wants to merge 1 commit into
s0nskar wants to merge 1 commit into
Conversation
…_AND_REPLICATE_PAUSED
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3720 +/- ##
==========================================
+ Coverage 66.91% 67.09% +0.18%
==========================================
Files 358 359 +1
Lines 21986 22304 +318
Branches 1946 1982 +36
==========================================
+ Hits 14710 14962 +252
- Misses 6262 6319 +57
- Partials 1014 1023 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Partition file sorting should only be paused for
PUSH_AND_REPLICATE_PAUSED, which represent very high memory pressure and cause OOM for workers. Sorting should be allowed forPUSH_PAUSEDstate.Why are the changes needed?
Currently even for push pause state we stop the sorting for partition files. If pause is sustained for a longer time then sorting can timeout and reader waiting for sorting will fail or be delayed.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
Existing UTs