feat(components): micrometer supports prometheus format by squakez · Pull Request #25444 · apache/camel

squakez · 2026-08-11T10:04:07Z

Add a conversion to support the feature from this component instead of the prometheus one

Ref CAMEL-24356

Description

Target

I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

I checked that each commit in the pull request has a meaningful subject line and body.

I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

github-actions · 2026-08-11T10:36:36Z

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

First-time contributors require MANUAL approval for the GitHub Actions to run
You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

github-actions · 2026-08-11T10:59:40Z

🧪 CI tested the following changed modules:

catalog/camel-catalog
components/camel-micrometer-prometheus
components/camel-micrometer
core/camel-main

ℹ️ Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the test-dependents label to force testing all dependents.

🔬 Scalpel shadow comparison — Scalpel: 65 tested, 28 compile-only — current: 64 all tested

Maveniverse Scalpel detected 93 affected modules (current approach: 64).

⚠️ Modules only in Scalpel (29)

apache-camel
camel-allcomponents
camel-catalog
camel-catalog-console
camel-catalog-lucene
camel-catalog-maven
camel-catalog-suggest
camel-componentdsl
camel-csimple-maven-plugin
camel-endpointdsl
camel-endpointdsl-support
camel-itest
camel-jbang-core
camel-jbang-it
camel-jbang-main
camel-jbang-plugin-edit
camel-jbang-plugin-generate
camel-jbang-plugin-kubernetes
camel-jbang-plugin-test
camel-kamelet-main
camel-launcher
camel-report-maven-plugin
camel-route-parser
camel-yaml-dsl
camel-yaml-dsl-deserializers
camel-yaml-dsl-maven-plugin
coverage
docs
dummy-component

Skip-tests mode would test 65 modules (4 direct + 61 downstream), skip tests for 28 (generated code, meta-modules)

Modules Scalpel would test (65)

camel-a2a
camel-as2
camel-catalog
camel-clickup
camel-consul
camel-core-all
camel-csv
camel-fhir
camel-groovy
camel-hazelcast
camel-hl7
camel-ibm-watsonx-ai
camel-iso8583
camel-java-joor-dsl
camel-jbang-mcp
camel-jbang-plugin-mcp
camel-jbang-plugin-route-parser
camel-jbang-plugin-tui
camel-jbang-plugin-validate
camel-jetty
camel-jsonpath
camel-kamelet
camel-kamelet-main-support
camel-knative-http
camel-launcher-container
camel-mail
camel-mail-microsoft-oauth
camel-main
camel-maven-plugin
camel-mcp-server
camel-micrometer
camel-micrometer-prometheus
camel-microprofile-health
camel-netty
camel-netty-http
camel-oauth
camel-observability-services
camel-once
camel-openapi-validator
camel-platform-http-main
camel-platform-http-vertx
camel-plc4x
camel-pubnub
camel-quickfix
camel-resilience4j-micrometer
camel-rest-openapi
camel-restdsl-openapi-plugin
camel-salesforce
camel-salesforce-codegen
camel-salesforce-maven-plugin
camel-spring-main
camel-syslog
camel-telegram
camel-test-main-junit5
camel-test-main-junit6
camel-vertx-websocket
camel-webhook
camel-whatsapp
camel-xml-io-dsl
camel-xml-jaxb-dsl
camel-xml-jaxb-dsl-test-definition
camel-xml-jaxb-dsl-test-spring
camel-yaml-dsl-validator
camel-yaml-dsl-validator-maven-plugin
camel-zookeeper

Modules with tests skipped (28)

apache-camel
camel-allcomponents
camel-catalog-console
camel-catalog-lucene
camel-catalog-maven
camel-catalog-suggest
camel-componentdsl
camel-csimple-maven-plugin
camel-endpointdsl
camel-endpointdsl-support
camel-itest
camel-jbang-core
camel-jbang-it
camel-jbang-main
camel-jbang-plugin-edit
camel-jbang-plugin-generate
camel-jbang-plugin-kubernetes
camel-jbang-plugin-test
camel-kamelet-main
camel-launcher
camel-report-maven-plugin
camel-route-parser
camel-yaml-dsl
camel-yaml-dsl-deserializers
camel-yaml-dsl-maven-plugin
coverage
docs
dummy-component

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

Build reactor — dependencies compiled but only changed modules were tested (93 modules)

Camel :: AI :: A2A
Camel :: AI :: MCP Server
Camel :: AS2 :: Component
Camel :: All Components Sync point
Camel :: All Core Sync point
Camel :: Assembly
Camel :: CSV
Camel :: Catalog :: CSimple Maven Plugin (deprecated)
Camel :: Catalog :: Camel Catalog
Camel :: Catalog :: Camel Report Maven Plugin
Camel :: Catalog :: Camel Route Parser
Camel :: Catalog :: Console
Camel :: Catalog :: Dummy Component
Camel :: Catalog :: Lucene (deprecated)
Camel :: Catalog :: Maven
Camel :: Catalog :: Suggest
Camel :: ClickUp
Camel :: Component DSL
Camel :: Consul
Camel :: Coverage
Camel :: Docs
Camel :: Endpoint DSL
Camel :: Endpoint DSL :: Support
Camel :: FHIR
Camel :: Groovy
Camel :: HL7
Camel :: HazelCast
Camel :: IBM :: watsonx.ai
Camel :: ISO-8583
Camel :: Integration Tests
Camel :: JBang :: Core
Camel :: JBang :: Integration tests
Camel :: JBang :: MCP
Camel :: JBang :: Main
Camel :: JBang :: Plugin :: Edit
Camel :: JBang :: Plugin :: Generate
Camel :: JBang :: Plugin :: Kubernetes
Camel :: JBang :: Plugin :: MCP
Camel :: JBang :: Plugin :: Route Parser
Camel :: JBang :: Plugin :: TUI
Camel :: JBang :: Plugin :: Testing
Camel :: JBang :: Plugin :: Validate
Camel :: JSon Path
Camel :: Java DSL with jOOR
Camel :: Jetty
Camel :: Kamelet
Camel :: Kamelet Main
Camel :: Kamelet Main :: Support
Camel :: Knative HTTP
Camel :: Launcher
Camel :: Launcher :: Container
Camel :: Mail
Camel :: Mail :: Microsoft OAuth
Camel :: Main
Camel :: Maven Plugins :: Camel Maven Plugin
Camel :: Maven Plugins :: OpenApi REST DSL Generator
Camel :: MicroProfile :: Health
Camel :: Micrometer
Camel :: Micrometer :: Prometheus
Camel :: Netty
Camel :: Netty HTTP
Camel :: OAuth
Camel :: Observability Services
Camel :: Once
Camel :: OpenAPI :: Validator
Camel :: PLC4X
Camel :: Platform HTTP :: Main
Camel :: Platform HTTP :: Vert.x
Camel :: PubNub
Camel :: QuickFIX/J
Camel :: REST OpenApi
Camel :: Resilience4j :: Micrometer
Camel :: Salesforce
Camel :: Salesforce :: CodeGen
Camel :: Salesforce :: Maven Plugin
Camel :: Spring Main
Camel :: Syslog
Camel :: Telegram
Camel :: Test :: Main :: JUnit5
Camel :: Test :: Main :: JUnit6
Camel :: Vert.x :: WebSocket
Camel :: Webhook
Camel :: Whatsapp
Camel :: XML DSL Jaxb :: Test :: Definition
Camel :: XML DSL Jaxb :: Test :: Spring
Camel :: XML DSL with camel-xml-io
Camel :: XML DSL with camel-xml-jaxb
Camel :: YAML DSL
Camel :: YAML DSL :: Deserializers
Camel :: YAML DSL :: Maven Plugins
Camel :: YAML DSL :: Validator
Camel :: YAML DSL :: Validator Maven Plugin
Camel :: Zookeeper

⚙️ View full build and test results

davsclaus

Nice work moving the Prometheus format support down to camel-micrometer — making it available without the Prometheus registry dependency is a good architectural improvement. The test coverage is thorough.

A few items below — one naming concern and two minor style points.

Note: This review covers project rules, conventions, and code correctness visible from the diff. It does not replace specialized review tools (CodeRabbit, Sourcery) or static analyzers (SonarCloud).

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Add a conversion to support the feature from this component instead of the prometheus one Ref CAMEL-24356

davsclaus

Thanks for moving the Prometheus format support down to camel-micrometer — nice refactor that makes the feature available without requiring the prometheus extension.

I found one code-quality issue that should be fixed before merging, plus a convention item.

This review focuses on project conventions and code correctness. It does not replace specialized review tools (CodeRabbit, Sourcery) or static analyzers (SonarCloud).

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

davsclaus · 2026-08-11T14:27:12Z

    private boolean skipCamelInfo = false;
    private boolean logMetricsOnShutdown = false;
    private String logMetricsOnShutdownFilters[];
+    private String logMetricsOnShutdownFormat;


This field defaults to null, but doStart() unconditionally passes it to registryService.setLogMetricsOnShutdownFormat(...), which overwrites the service's "json" default with null when the notifier is used standalone (without MicrometerPrometheus). The code still behaves correctly because "prometheus".equalsIgnoreCase(null) is false, but a getLogMetricsOnShutdownFormat() call on the service would return null instead of the documented "json" default.

Note how MicrometerPrometheus.doInit() guards the setter with if (getLogMetricsOnShutdownFormat() != null) — this class should be consistent.

Suggested change

private String logMetricsOnShutdownFormat;

private String logMetricsOnShutdownFormat = "json";

squakez mentioned this pull request Aug 11, 2026

feat(starters): micrometer support logMetricsOnShutdownFormat apache/camel-spring-boot#1884

Draft

github-actions Bot added components core catalog docs labels Aug 11, 2026

davsclaus reviewed Aug 11, 2026

View reviewed changes

squakez force-pushed the feat/CAMEL-24356 branch from 7312dd6 to 5fee9a1 Compare August 11, 2026 12:48

feat(components): micrometer supports prometheus format

98be1f9

Add a conversion to support the feature from this component instead of the prometheus one Ref CAMEL-24356

squakez force-pushed the feat/CAMEL-24356 branch from 5fee9a1 to 98be1f9 Compare August 11, 2026 13:46

davsclaus requested changes Aug 11, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat(components): micrometer supports prometheus format - #25444

feat(components): micrometer supports prometheus format#25444
squakez wants to merge 1 commit into
apache:mainfrom
squakez:feat/CAMEL-24356

squakez commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026 •

edited

Loading

Uh oh!

davsclaus left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davsclaus left a comment

Uh oh!

davsclaus Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	private String logMetricsOnShutdownFormat;
	private String logMetricsOnShutdownFormat = "json";

Uh oh!

Conversation

squakez commented Aug 11, 2026

Description

Target

Tracking

Apache Camel coding standards and style

AI-assisted contributions

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davsclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davsclaus left a comment

Choose a reason for hiding this comment

Uh oh!

davsclaus Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Aug 11, 2026 •

edited

Loading