CAMEL-22527: Fix flaky HttpRouteTest and JettyFailoverRoundRobinTest#22982
Open
gnodet wants to merge 2 commits intoapache:mainfrom
Open
CAMEL-22527: Fix flaky HttpRouteTest and JettyFailoverRoundRobinTest#22982gnodet wants to merge 2 commits intoapache:mainfrom
gnodet wants to merge 2 commits intoapache:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
May 6, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🧪 CI tested the following changed modules:
Build reactor — dependencies compiled but only changed modules were tested (2 modules)
|
oscerd
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-22527
Fixes two flaky tests in
camel-jetty:HttpRouteTest.testEchoEndpoint
The
enableSessionSupportmethod inJettyHttpComponentthrewIllegalStateExceptionwhen session support was requested on a Jetty server that was already started (e.g., when another route on the same port was connected first). Instead of throwing, the fix restarts the server to add session support — matching the existing pattern for handler changes. TheJettySessionSupportTestis updated to verify the new behavior: session support now works correctly even when added to a port that already has other routes.JettyFailoverRoundRobinTest.testJettyFailoverRoundRobin
The test assumed the failover round-robin load balancer always starts at index 0, but the starting index can vary depending on the
AtomicIntegercounter state. The fix verifies that both good endpoints are reached across two requests (confirming both failover and round-robin behavior) without assuming a specific starting index.