CAMEL-23195 Implement camel-pulsar SubscriptionMode configuration#21995
Open
klevy-toast wants to merge 2 commits intoapache:mainfrom
Open
CAMEL-23195 Implement camel-pulsar SubscriptionMode configuration#21995klevy-toast wants to merge 2 commits intoapache:mainfrom
klevy-toast wants to merge 2 commits intoapache:mainfrom
Conversation
oscerd
approved these changes
Mar 13, 2026
gnodet
approved these changes
Mar 13, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
LGTM. Clean implementation following the existing patterns for SubscriptionType and SubscriptionInitialPosition. The SubscriptionMode enum properly wraps the Pulsar client enum, the @UriParam annotation is correct with appropriate defaults, and the single-line wiring in CommonCreationStrategyImpl is clean. Test coverage is good.
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements subscription modes in camel-pulsar consumers, allowing the user to specify a non-durable subscription. Defaults to durable, which matches the existing behavior.
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.