Skip to content

CAMEL-23195 Implement camel-pulsar SubscriptionMode configuration#21995

Open
klevy-toast wants to merge 2 commits intoapache:mainfrom
klevy-toast:CAMEL-23195-pulsar-subscription-mode
Open

CAMEL-23195 Implement camel-pulsar SubscriptionMode configuration#21995
klevy-toast wants to merge 2 commits intoapache:mainfrom
klevy-toast:CAMEL-23195-pulsar-subscription-mode

Conversation

@klevy-toast
Copy link
Contributor

Description

Implements subscription modes in camel-pulsar consumers, allowing the user to specify a non-durable subscription. Defaults to durable, which matches the existing behavior.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean implementation following the existing patterns for SubscriptionType and SubscriptionInitialPosition. The SubscriptionMode enum properly wraps the Pulsar client enum, the @UriParam annotation is correct with appropriate defaults, and the single-line wiring in CommonCreationStrategyImpl is clean. Test coverage is good.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants