[CALCITE-7354] Add assertion that the size of the Project's variablesSet should be less than or equal to 1#4865
Conversation
…Set should be less than or equal to 1
|
| Project project, | ||
| ImmutableBitSet fieldsUsed, | ||
| Set<RelDataTypeField> extraFields) { | ||
| checkArgument(project.getVariablesSet().size() <= 1, |
There was a problem hiding this comment.
Perhaps including the actual size in the error message would make troubleshooting easier.
| Project project, | ||
| ImmutableBitSet fieldsUsed, | ||
| Set<RelDataTypeField> extraFields) { | ||
| checkArgument(project.getVariablesSet().size() <= 1, |
There was a problem hiding this comment.
I feel that making a judgment at the beginning is not a good choice.
|
I am not entirely sure if this original requirement is correct; is it absolutely certain that |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions. |
3 participants
Jira Link
CALCITE-7354
Changes Proposed
Added
checkArgument()assertion to ensureproject.getVariablesSet().size()contains at most one correlation variable in RelFieldTrimmer.