[CALCITE-7431] RelTraitSet#getTrait seems to mishandle RelCompositeTrait#4827
[CALCITE-7431] RelTraitSet#getTrait seems to mishandle RelCompositeTrait#4827xiedeyantu wants to merge 2 commits intoapache:mainfrom
Conversation
|
I don't know how to make these two systems fully compatible. I support improving the error messages between them. Therefore, this PR doesn't solve the problem. I don't know if it's worthwhile. |
| * {@link RelDistributionTraitDef#INSTANCE} to retrieve all values. | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public <T extends RelDistribution> @Nullable T getDistribution() { |
There was a problem hiding this comment.
If I understand correctly, getTrait and getCollation will throw an error, while getDistribution returns the first element. These are two different strategies. Can you please explain this?
There was a problem hiding this comment.
This was indeed an overlooked point, and I've already made corrections based on the comments. I'm not sure if this PR will be useful, as it doesn't address the root cause.
|
2 participants
See CALCITE-7431